Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: re-broadcast stale txs #739

Closed
wants to merge 30 commits into from
Closed

feat: re-broadcast stale txs #739

wants to merge 30 commits into from
+1,552 −1,488

Conversation

boecklim
Copy link
Collaborator

@boecklim boecklim commented Jan 9, 2025 •
edited
Loading

Description of Changes

This PR is intended to replace: #691

  • Transactions that are ONLY in the STALE chain and are not found in the longest chain, will try to be re-announced to the network and circle back from statuses SEEN_ON_NETWORK forward.
  • Removed option onlyLongestChain from GetMinedTransactions blocktx store method.
  • Respecting height range in GetChainTip blocktx store method.

Testing Procedure

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes

boecklim and others added 30 commits January 6, 2025 16:01
@boecklim
refactor(ARCO-312): Do not store Merkle paths
2f373eb
@boecklim
refactor(ARCO-312): Add height to log
d2e01e4
@boecklim
refactor(ARCO-312): Increase batch size
c214259
@boecklim
refactor(ARCO-312): Fix test
09e26b0
@boecklim
refactor(ARCO-312): Rm comment
fbd4475
@boecklim
refactor(ARCO-312): Processing speed of block
37578db
@boecklim
refactor(ARCO-312): Remove unused indices
ff692e4
@boecklim
refactor(ARCO-312): Reduce code duplication
7c01ab2
@boecklim
refactor(ARCO-312): Make lint
4651939
@boecklim
refactor(ARCO-312): Remove unused inserted_at field in block_transact…
c61468a 
…ions table
@boecklim
refactor(ARCO-312): Store transactions in parallel
e46d00a
@boecklim
refactor(ARCO-312): Show progress for steps
4cfcb13
@boecklim
refactor(ARCO-312): Check correctness of Merkle paths
fd10a67
@boecklim
refactor(ARCO-312): revert temporarily stop reorg support handling to…
5361135 
… allow for processing mined transactions when gaps are existing (#716). This reverts commit ba20b1b.
@boecklim
refactor(ARCO-312): Assigning block status depending on setting
cfb9928
@boecklim
refactor(ARCO-312): Fix tests
2747a3c
@boecklim
refactor(ARCO-312): Remove unused fixture
aa720f7
@boecklim
refactor(ARCO-312): Revert comments
0b399e7
@boecklim
refactor(ARCO-312): Capitalize error log
fb953fc
@boecklim
refactor(ARCO-312): Use hex string for map key
bdb3e9e
@boecklim
refactor(ARCO-312): Fix comment
ac19675
@boecklim
refactor(ARCO-312): Fix integration tests
cbdcf74
@boecklim
refactor(ARCO-312): Refactor opts
0770104
@boecklim
refactor(ARCO-312): Setting which decides whether a received block is…
e97e4a5 
… considered from the longest blockchain by default
@kuba-4chain @boecklim
feat: re-broadcast stale txs
471f1f7
@kuba-4chain @boecklim
feat: documentation update
1a8e526
@kuba-4chain @boecklim
feat: include height range in getting the chain tip
e589813
@kuba-4chain @boecklim
feat: update e2e test
a6c396d
@kuba-4chain @boecklim
fix: uncomment blockhash
1cb3d84
@boecklim
fix: Fix after rebase
4c79510
@boecklim boecklim changed the base branch from main to feat/reactivate-reorg-support January 9, 2025 16:24
@boecklim boecklim self-assigned this Jan 9, 2025
@boecklim boecklim force-pushed the feat/reactivate-reorg-support branch 9 times, most recently from 4417bb8 to 5885e6e Compare January 16, 2025 14:24
@boecklim
Copy link
Collaborator Author

Closing for now as feature not a high priority

@boecklim boecklim closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@boecklim boecklim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boecklim @kuba-4chain